Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify wallet API and rework internal imple #15

Merged
merged 9 commits into from
Oct 15, 2023

Conversation

AaronCQL
Copy link
Member

@AaronCQL AaronCQL commented Oct 15, 2023

  • Simplified wallet APIs
    • getAccount(): reworked to getAuthInfo(), but consumers are no longer required to call this method to broadcast transactions
    • pollTx(): removed and combined with broadcastTx()
    • estimateFee(): second parameter now accepts the feeMultiplier directly (still optional)
    • broadcastTx(): second parameter now accepts the fee from the result of estimateFee() (no longer optional)
    • broadcastTxWithFeeEstimation(): newly added function that combines estimateFee and broadcastTx
  • Handle account sequence mismatch errors directly in ConnectedWallet.estimateFee() by retrying once with the correct sequence
  • Re-exported @keplr-wallet/types from cosmes/registry
  • Updated benchmarks with Cosmos Kit

@AaronCQL AaronCQL self-assigned this Oct 15, 2023
@AaronCQL AaronCQL merged commit 1ec6e21 into main Oct 15, 2023
1 check passed
@AaronCQL AaronCQL deleted the aaron/refactor-wallet branch October 15, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant