Add colcon test verb #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
5 tasks
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
luca-della-vedova
force-pushed
the
luca/add_test
branch
from
021a074
to
e80cddf
Compare
jhdcs
approved these changes
Jul 12, 2024
maspe36
approved these changes
Jul 19, 2024
esteve
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8
Depends on colcon/colcon-cargo#39.
I did some back and forth between whether
cargo buildshould also build tests or not. In the end I settled on "no" because doing so would require passing custom arguments as shown in e80cddf.However, a
cargo buildcustom command would fail if the underlying package is missing any of the required components, for example if there are no libraries or if there are no binaries.The alternative would have been to try to parse the package and generate the correct
cargo buildinvocation, but that would have made the implementation fairly more complex.The implementation of the actual test takes place in
colcon-cargoso this PR is pretty bare.