Fixed 2948459

[jaapjansma]

Overview

Bug fix of a bug which occured in certain versions of civicrm in combination with a certain version of webform_civicrm module.

• CiviCRM version 4.7.29
• Webform_civicrm version 7.x-4.20

Before

When one adds a webform with address details on it (for example a webform where a new person is registered into civicrm) the address creation will fail. The contact will be created, email address will be created but no address on the contact record,
The failure could be found in the Drupal Log and the address submitted as well.

After

When one adds a webform with address details on it (for example a webform where a new person is registered into civicrm) the address creation will succeed. The contact will be created, email address will be created and an address record is created

Technical Details

This was caused by the fact that master_id was set to 'null' and that did not work in address create api. Unsetting the master_id parameter fixed it.

[colemanw]

@jaapjansma could you please give steps to reproduce this bug, as well as the versions affected? Thanks.

[jaapjansma]

@colemanw I have updated the description of the PR and included how to reproduce the bug.

[colemanw]

That really sounds like a bug in the CiviCRM API. Value of 'null' is legitimate input, and should not cause a failure.

[colemanw]

I just tried to reproduce the bug in the Api Explorer* (in the latest CiviCRM master branch) and could not.
@jaapjansma am I missing something?

* The api explorer doesn't allow random strings in that field (it tries to let you autocomplete existing addresses instead) so I had to do this hack in the browser console to actually test this: cj('input.crm-address-ref').crmSelect2('destroy');

[jaapjansma]

You need CiviCRM version 4.7.29. It is fixed in the latest civicrm

[jaapjansma]

The regression has been fixed in this PR: civicrm/civicrm-core#11324

[colemanw]

Ok, since the bug has been fixed upstream I think we can close this. Not setting the shared address to null could result in other bugs so I think it's best to leave as-is.