-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored: works for multiple password inputs, fixes regarding autofill… #48
base: main
Are you sure you want to change the base?
Conversation
- Works with multiple `input[type=password]`. - The `aria-label` of the toggle button can be customized adding `data-show` and `data-hide` attributes to the password input. - The toggle button is added by JavaScript, remove existing `<button>` tags. - The toggle button works more stable. - The toggle button is always visible.
Put the background icon to the button instead the password input to avoid hidden icon with autofill.
Solves issue coliff#24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
# Conflicts: # package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
input[type=password]
.aria-label
of the toggle button can be customized addingdata-show
anddata-hide
attributes to the password input.<button>
tags when upgrading.aria-pressed
attribute to the toggle button.