Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch button icons to show effect, not status #83

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Conversation

dan-jensen
Copy link
Contributor

Description

This switches the button icons so they indicate the effect they will
have if clicked, instead of the current status. This will make it more
obvious that the button is a button, and what effect it will have if clicked.

Motivation and Context

Clickable buttons generally indicate the effect they will have if
clicked. For example, if a video is playing there is usually a pause button to indicate the video will become paused if the pause button is clicked.

Previously, the buttons in this plugin looked like
status indicators instead of buttons. When the password was hidden by default,
the button showed the "not visible" icon. That meant it was not necessarily obvious
the button was a button.

How Has This Been Tested?

Currently running in a production environment, see https://www.pocketero.com/users/open-account

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (aesthetic only)

Checklist

  • My code follows the code style of this project.

Gratitude

@coliff thanks for creating this plugin, it works great! 👍

Clickable buttons generally indicate the effect they will have if
clicked. Non-clickable status indicators generally indicate the
current status.

This switches the button icons so they indicate the effect they will
have if clicked, instead of the current status.
@dan-jensen dan-jensen changed the title Switch buttons to show effect, not status Switch button icons to show effect, not status Jun 14, 2022
@coliff coliff self-requested a review June 14, 2022 23:43
@coliff
Copy link
Owner

coliff commented Jun 28, 2022

thanks for this. well spotted. :-) This now matches the UI that Microsoft IE11 and Edge use.
Tested using simple <input type="password" /> test-case: https://input-type-password.stackblitz.io/

@coliff coliff enabled auto-merge June 28, 2022 07:44
@coliff coliff merged commit 32635f7 into coliff:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants