Solved flickering bug for dark mode and added script to head #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging 5fd8d89 into 00e0ed3 - view on LGTM.com new alerts:
|
mattfleaydaly
referenced
this pull request
in popoway/dark-mode-switch
Nov 9, 2020
Attempt to fulfill issue coliff#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a flickering issue when dark mode was selected and the page was refreshed or opened.
I've added a function that creates a style element with the theme colors and can switch from lightmode to darkmode. I've used this as a source: StackOverflow
In order to fully resolve the flickering issue, the script must be included in the head element
Motivation and Context
Flickering issue described here: Github issue
How Has This Been Tested?
The changes can be tested by running index.html
Types of changes
Checklist: