-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structural error #169
Structural error #169
Conversation
Thanks for submitting this. It's going to be a couple days before I can test it locally, but once I do I'll be able to provide the final review and will merge if everything looks good. |
2e186ff
to
e29f1cc
Compare
@TedDriggs any updates on this? |
Sorry, my day job has been taking up a lot of my time and I haven't had a chance to test this. I think the code is all good, and the hangup is purely my "rustiness" with this code base. Here are my outstanding concerns:
Generating an error per builder is a much cleaner solution than trying to make one structured error that the main crate emits. That's definitely the right path forward. I'm wondering if a good interim path forward is:
Thoughts? |
0.10.0-alpha/beta versions can be released for early adopters. SemVer helps here. Only those who use version |
You are right. There used to be no_std tests, but I ended up disabling them because they broke too often. Let's move ahead with this on |
e29f1cc
to
18e1606
Compare
Conflicts are resolved. |
I'm still thinking about the name of the variant for validation errors; I think I might switch it to |
My apologies, it's a little difficult for me to follow the macro shenanigans. It seems like the return type of the validator is now |
Ok, wait, I'm sorry. I think I've got that wrong. |
My attempt to resolve #60