Update to syn 2 and darling 0.20.5 #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump crates to 2018 edition; this is needed for generated code to produce usable error messages. - Bump darling dependency to 0.20.5 - Remove support for `field(type = "...")` and leave only `field(ty = "...")` - Update compiletest outputs Remove interim change
This makes click-to-definition work when reading source code
jtran
approved these changes
Feb 12, 2024
|
I'm going to wait to merge this until TedDriggs/darling#263 has landed, as I may want to ship with a darling dependency of 0.20.6 instead of 0.20.5. However, that hopefully won't take long to resolve, and at that point this will be unblocked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the most recent major version of
syn, as well as the most recent version ofdarling.Breaking Changes
typeto override the type of a field; instead,tymust be used.Fixes #292