Remove createParams cascade from .array() (#3530)

colinhacks · Dec 10, 2024 · 3755146 · 3755146
1 parent 6407bed
commit 3755146
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 2 deletions.
diff --git a/deno/lib/__tests__/description.test.ts b/deno/lib/__tests__/description.test.ts
@@ -26,3 +26,11 @@ test("description should carry over to chained schemas", () => {
     description
   );
 });
+
+test("description should not carry over to chained array schema", () => {
+  const schema = z.string().describe(description)
+
+  expect(schema.description).toEqual(description);
+  expect(schema.array().description).toEqual(undefined);
+  expect(z.array(schema).description).toEqual(undefined);
+})
diff --git a/deno/lib/types.ts b/deno/lib/types.ts
@@ -434,7 +434,7 @@ export abstract class ZodType<
     return this.nullable().optional();
   }
   array(): ZodArray<this> {
-    return ZodArray.create(this, this._def);
+    return ZodArray.create(this);
   }
   promise(): ZodPromise<this> {
     return ZodPromise.create(this, this._def);

diff --git a/src/__tests__/description.test.ts b/src/__tests__/description.test.ts
@@ -25,3 +25,11 @@ test("description should carry over to chained schemas", () => {
     description
   );
 });
+
+test("description should not carry over to chained array schema", () => {
+  const schema = z.string().describe(description)
+
+  expect(schema.description).toEqual(description);
+  expect(schema.array().description).toEqual(undefined);
+  expect(z.array(schema).description).toEqual(undefined);
+})
diff --git a/src/types.ts b/src/types.ts
@@ -434,7 +434,7 @@ export abstract class ZodType<
     return this.nullable().optional();
   }
   array(): ZodArray<this> {
-    return ZodArray.create(this, this._def);
+    return ZodArray.create(this);
   }
   promise(): ZodPromise<this> {
     return ZodPromise.create(this, this._def);