early return on own issues

colinhacks · Jan 10, 2024 · 83e8ea4 · 83e8ea4
1 parent 2e7ab71
commit 83e8ea4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/deno/lib/types.ts b/deno/lib/types.ts
@@ -4264,8 +4264,10 @@ export class ZodEffects<
 
     const effect = this._def.effect || null;
 
+    let hasIssue = false;
     const checkCtx: RefinementCtx = {
       addIssue: (arg: IssueData) => {
+        hasIssue = true;
         addIssueToContext(ctx, arg);
         if (arg.fatal) {
           status.abort();
@@ -4282,7 +4284,7 @@ export class ZodEffects<
 
     if (effect.type === "preprocess") {
       const processed = effect.transform(ctx.data, checkCtx);
-      if (ctx.common.issues.length) {
+      if (hasIssue) {
         return {
           status: "dirty",
           value: ctx.data,

diff --git a/src/types.ts b/src/types.ts
@@ -4264,8 +4264,10 @@ export class ZodEffects<
 
     const effect = this._def.effect || null;
 
+    let hasIssue = false;
     const checkCtx: RefinementCtx = {
       addIssue: (arg: IssueData) => {
+        hasIssue = true;
         addIssueToContext(ctx, arg);
         if (arg.fatal) {
           status.abort();
@@ -4282,7 +4284,7 @@ export class ZodEffects<
 
     if (effect.type === "preprocess") {
       const processed = effect.transform(ctx.data, checkCtx);
-      if (ctx.common.issues.length) {
+      if (hasIssue) {
         return {
           status: "dirty",
           value: ctx.data,