add .dateISOString() format
#1489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for guileless-rolypoly-866f8a ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a validator for what I think is a fairly common and universally accessible format in Javascript: Date.prototype.toISOString().
I've gone down a fairly big rabbit hole of threads but I think this makes sense and is fairly clear. Since the RFC Colin #126 (comment) here raised that
.utc()should support milliseconds but not required could lead to some inconsistencies in codebases so I've decided to go a different route. I feel like I would likely want to choose milliseconds or no milliseconds for consistency. Hence I've decided to go with just this simple.dateISOString()which is also documented to be pointing to theDate.prototype.toISOString()functionHappy to be shot down here if we could get some progress.