Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed freezing async ZodReadonly results #3457

Merged
merged 3 commits into from
May 2, 2024

Conversation

zsilbi
Copy link
Contributor

@zsilbi zsilbi commented May 2, 2024

Hello!

I noticed that the parsed results of readonly() schemas are not really readonly after parseAsync()
I added tests, then a fix. (and corrected a minor typo in the related docs)

  • Your code changes are well-documented.
  • You have tested your changes.
  • You have updated any relevant documentation.

Copy link

netlify bot commented May 2, 2024

Deploy Preview for guileless-rolypoly-866f8a ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d06b4d6
🔍 Latest deploy log https://app.netlify.com/sites/guileless-rolypoly-866f8a/deploys/6633b13b65dd940008e74b37
😎 Deploy Preview https://deploy-preview-3457--guileless-rolypoly-866f8a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@colinhacks
Copy link
Owner

colinhacks commented May 2, 2024

Good catch. Thanks!

@colinhacks colinhacks merged commit 04e1f37 into colinhacks:master May 2, 2024
4 checks passed
@colinhacks
Copy link
Owner

Landed in v3.23.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants