Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protection. load shutdown if the temperature sensor data is not corre… #1

Open
wants to merge 1 commit into
base: pid_branch
Choose a base branch
from

Conversation

AlexTransit
Copy link

For work, you can only use the internal DS18B20 library.
which returns zero if there is no data from the sensor. (This code does not work with other libraries.)

To prevent an emergency, the code disables the load if there are no temperature sensor data.

…ct or unavailable.

For work, you can only use the internal DS18B20 library.
which returns zero if there is no data from the sensor. (This code does not work with other libraries.)

To prevent an emergency, the code disables the load if there are no temperature sensor data.
colinl pushed a commit that referenced this pull request Oct 14, 2018
colinl pushed a commit that referenced this pull request Oct 14, 2018
Added support for MPU6050 gyro sensor
colinl pushed a commit that referenced this pull request Oct 14, 2018
colinl pushed a commit that referenced this pull request Oct 14, 2018
@thucar
Copy link

thucar commented Jan 14, 2020

Maybe instead disabling the load, use the pid_manual_power instead? This way there would be a degree of adjustment available. For instance if using this for some sort of heating in subzero environments, having the load on a low value is better than switching it off.

@colinl
Copy link
Owner

colinl commented Jan 14, 2020

In fact I never understood what this PR was actually about. The proposal to assume that the value is invalid if it is zero is obviously flawed as zero is a perfectly valid value. In fact I have never seen a faulty sensor return zero, my experience is that no value is acquired at all, so after a time of PID_MAX_INTERVAL the power will revert to that specified for PID_MANUAL_POWER, which can be configured (or set) to whatever value is required.
I am sure I had this discussion with the OP but I can't see it now, which is odd.

@Bournetoride
Copy link

MAX6675 returns zero if not connected

@colinl
Copy link
Owner

colinl commented Dec 27, 2020

@Bournetoride how do you know whether the zero that it returns is a real value of zero or a fault?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants