Pid branch to address issue #15

[marcvs]

Description:

Related issue (if applicable): fixes #

Checklist:

• The pull request is done against the latest dev branch
• Only relevant files were touched
• Only one feature/fix was added per PR.
• The code change is tested and works on core 2.3.0, 2.4.2, 2.5.2, and pre-2.6
• The code change pass travis tests. Your PR cannot be merged unless tests pass
• I accept the CLA.

[colinl]

That all looks ok, but I am not able to test it at the moment. Do you feel you have given it sufficient testing?

[marcvs]

From experience I can hardly answer "yes" to this question in general. Here's what I can say:

• It works as expected
• It didn't crash in the last ~17h
• I can still use the web interface fluently (despite a load of 19)
• It runs Core/SDK Version 2_7_4_9/2.2.2-dev(38a443e)
• I'm willing to support it, in case of problems.

[colinl]

That's great. Have you been able to test setting parameters via MQTT? I don't think it is necessary to test them all, if you check a couple of them I will check the code changes carefully so the rest should be ok

[marcvs]

I'm only setting them via MQTT. That worked fine.

[colinl]

OK, are you happy for me to merge it now or is there anything else you want to do?

[marcvs]

I think it's fine.

I'll then also send the PR to arendst/development, as @ascillato suggested, right?

[ascillato]

I'll then also send the PR to arendst/development, as @ascillato suggested, right?

Great, Thanks 👍

[marcvs]

For the record: the PR against arendst/Tasmota is here: arendst#10412

[colinl]

I understand the confusion early on in the issue now, I didn't realise that the pid branch had been incorporated into the arendst code. When I initially attempted to get it merged it was ignored, if I remember correctly.

[marcvs]

I've had some discussion with Theo in the other PR, that I've submitted.

I was not really sure about the Timeprop_Command in xdrv_91_timeprop.ino (

Sonoff-Tasmota/sonoff/xdrv_91_timeprop.ino

Line 152 in 2fef64d

boolean Timeprop_Command()

)

Functionality remained in place when I removed it. It looks like it was meant to receive commands for directly altering timeprop functionality. What shall I do about it?

xdrv_92_pid.ino contains two lines to publish PID power:

Sonoff-Tasmota/sonoff/xdrv_92_pid.ino

Line 339 in 2fef64d

snprintf_P(mqtt_data, sizeof(mqtt_data), PSTR("{\"%s\":\"%s\"}"), "power", buf);

I've barred that behind an ifdef for backwards compatibility, as I've now managed to place the PID information into one JSON inside the /SENSOR topic (as I wanted to do years ago, but eventually had to face that I had no time).

It probably be easier to discuss one sole line of patches in the other PR, right?
arendst#10412