Skip to content

Commit

Permalink
build: use a separate git-cliff config for the bump-version job
Browse files Browse the repository at this point in the history
git-cliff has functionality to detect the next version, in addition to
the main functionality of generating changelogs. However, our config,
which skips `build` commits when generating the changelog, breaks the
"next version detection" capability if the previous version tag is on a
`build` commit (as it was for mmserver-v0.4.1).
  • Loading branch information
colinmarc committed Aug 25, 2024
1 parent d888ab6 commit 60041de
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/bump-version.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
comp_dir="mm-${{ matrix.component }}"
echo "COMPONENT_DIR=$comp_dir" | tee -a "$GITHUB_ENV"
version=$( git cliff -c .github/workflows/cliff.toml \
version=$( git cliff -c .github/workflows/cliff-bump-version.toml \
--bumped-version --unreleased \
--tag-pattern "${{ matrix.component }}" \
--include-path "$comp_dir/**/*" )
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/cliff-bump-version.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[bump]
features_always_bump_minor = true
breaking_always_bump_major = false

0 comments on commit 60041de

Please sign in to comment.