Begin fixing landing customization #148
Conversation
There is a surprising amount of content that depends on `$.Site.Data.landing`. This is bad and should be removed or made to use something default-but-changeable This changeset does exactly that. I've also reworked the way that iamge compare is checked for, which makes it possible to use it in the body content as well later as a shortcode. This also begins the process of making all scripts fingerprintable for SRI.
👷 Deploy request for hugo-lotusdocs pending review.Visit the deploys page to approve it
|
since we include it with context!
|
When is this PR get reviewed potentially merged? i had to update couple of things by manually to make the landing page works. Kudos to the creator. 👏 I love this theme. |
|
Nice to see this! It was driving me crazy and then decided to check the issues and prs. Looking forward to it getting merged. |
|
I'm pretty confident that this is ready for at least an initial review. Things that should be considered for a future change:
|
|
knock knock: Any chance of getting this merged? |
|
Would be great to see this merged. @colinwilson any chance you can have a look at this? |
| @import "custom/components/buttons"; | ||
| @import "custom/components/badge"; | ||
| @import "custom/components/backgrounds"; |
There was a problem hiding this comment.
IMHO, this should not be removed. This breaks the background-color of the nav-pills of the image-comparer and maybe other things as well
| {{- $imgviewjs := resources.Get "/js/image-compare-viewer.min.js" -}} | ||
| {{- $appjs := resources.Get "/js/app.js" -}} | ||
| {{- $bsjs := resources.Get "js/bootstrap.js" -}} | ||
| {{- $js := slice $bsjs $imgviewjs $appjs | resources.Concat "/js/bundle.js"}} |
There was a problem hiding this comment.
my tests show that the image-compare-viewer sources are not properly embedded:
Uncaught ReferenceError: ImageCompare is not defined
at bundle.js:1489:20
at NodeList.forEach (<anonymous>)
at bundle.js:1488:15
There is a surprising amount of content that depends on
$.Site.Data.landing. This is bad and should be removed or made to use something default-but-changeable This changeset does exactly that. I've also reworked the way that iamge compare is checked for, which makes it possible to use it in the body content as well later as a shortcode.This also begins the process of making all scripts fingerprintable for SRI.
TODO:
$.Page.Scratch.Getand related.Changes
landing.yamltolanding_default.yaml-> This should actually be indata/lotusdocsto namespace it away but I didn't want to make any sudden movements.$.Site.Data.landingto one.fixes #143 and future-proofs it a bit.