Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js garbage collection and hide playback #70

Closed
wants to merge 1 commit into from

Conversation

zang
Copy link
Contributor

@zang zang commented Apr 24, 2016

On Chrome, xhr stalls once file size reaches 500mb; create a restore function to release variables and therefore able to process further re-takes

@thijstriemstra
Copy link
Member

@zang thanks for the PR. As you can see the build is failing, you need to use parenthese etc. Make sure to run grunt locally before pushing the changes.

Is it possible to call this restore method as soon as it's trying to stall, or as soon as you stop recording? I'm not sure a standalone method like this is useful as it is now.

@zang
Copy link
Contributor Author

zang commented Apr 24, 2016

Sorry and I will sort out the checks :)

I had a strange issue recently and the recorded files stopped uploading after a few retakes. I use this function to clear the cached blobs and problem solved. I tried to add it to destroy() but the logic doesn't fit. I can't add it to finish recording as it will destroy the playback. So, I call this function after files being uploaded.

@zang
Copy link
Contributor Author

zang commented Apr 24, 2016

different browsers seem to have different file size limit before it stalls, and I can't find clear definition, that's why I didn't figure out how to add it to stall-detection. :)

@thijstriemstra
Copy link
Member

I had a strange issue recently and the recorded files stopped uploading after a few retakes.

We basically need to clear the previous blob when starting to record a new blob.

@thijstriemstra
Copy link
Member

chrome://blob-internals/ is a useful page in the Chrome browser to monitor the creation of blobs. I managed to get it down to 1 and will push a fix soon.

thijstriemstra added a commit that referenced this pull request May 9, 2016
@thijstriemstra
Copy link
Member

thijstriemstra commented May 9, 2016

@zang I've added a dispose method to engine and made sure all blobs are cleaned up afaik. Could you give this a try? The change you made related to resetting the playToggle, this looks similar to the request in #73 so I'll add a reset method there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants