Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

post hook fails if Docker is not running #79

Closed
davisagli opened this issue May 4, 2023 · 1 comment · Fixed by #143
Closed

post hook fails if Docker is not running #79

davisagli opened this issue May 4, 2023 · 1 comment · Fixed by #143

Comments

@davisagli
Copy link
Member

Generating a project fails if Docker is not running:
Screenshot 2023-05-04 at 1 35 54 PM

We should improve the docker pre-check to confirm not only the docker command version, but that the docker daemon is running. (Alternative: make the post hook succeed even if dockerd is not running)
@stevepiercy stevepiercy mentioned this issue Oct 7, 2023
Open
deruosi added a commit to deruosi/training that referenced this issue Oct 7, 2023
@deruosi
Update setup.md
8a90618 
refs collective/cookiecutter-plone-starter#79
justdaksh pushed a commit to plone/training that referenced this issue Oct 15, 2023
@deruosi @justdaksh
Update setup.md
ea4e60c 
refs collective/cookiecutter-plone-starter#79
@davisagli
Copy link
Member Author

Actually rather than require docker to be running in order to run the cookiecutter, I would suggest to just skip the "make format" command and print a warning about it if docker is not running.

@davisagli davisagli mentioned this issue Mar 7, 2024
Closed
@davisagli davisagli mentioned this issue Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make it possible to run the template without docker collective/cookiecutter-plone-starter
1 participant
@davisagli