Issue 56 - Fix Caching issues with WhatsApp button #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodfersou
force-pushed
the
issue_56
branch
4 times, most recently
from
48eca56 to
a8328e7
Compare
| self.execute_upgrade_step(step) | ||
|
|
||
| # Check | ||
| self.assertTrue(JS_ID in js_tool.getResourceIds()) |
There was a problem hiding this comment.
it breaks tests on Plone 4.1
rodfersou
force-pushed
the
issue_56
branch
3 times, most recently
from
8fc03e6 to
9b0d200
Compare
| @@ -7,12 +7,3 @@ | |||
| </div> | |||
| </tal:plugin> | |||
| </div> | |||
|
|
|||
There was a problem hiding this comment.
Moving this code to a better place.
rodfersou
force-pushed
the
issue_56
branch
2 times, most recently
from
491dbeb to
77fb912
Compare
| suite = unittest.TestSuite() | ||
| suite.addTests([ | ||
| layered( | ||
| robotsuite.RobotTestSuite(t, noncritical=['Expected Failure']), |
There was a problem hiding this comment.
@rodfersou you forgot to add this line
hvelarde
added a commit
that referenced
this pull request
Sep 16, 2015
Issue 56 - Fix Caching issues with WhatsApp button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #56