Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Audited RSpec Matchers #360

Merged
merged 1 commit into from
Dec 30, 2017
Merged

Fix typo in Audited RSpec Matchers #360

merged 1 commit into from
Dec 30, 2017

Conversation

hernanat
Copy link
Contributor

@hernanat hernanat commented Jul 7, 2017

Currently, the audited RSpec matchers throw an error:
undefined local variable or method 'expect' for <Audited::RspecMatchers::AuditMatcher:0x007f8627d6ae48>
when you use .only or .except.

The issue was a typo where it was referring to a non-existent variable expect instead of except.

Response to: #359

Currently, the audited RSpec matchers throw an error:
    undefined local variable or method 'expect' for <Audited::RspecMatchers::AuditMatcher:0x007f8627d6ae48>

when you use `.only` or `.except`.

The issue was a typo where it was referring to a non-existent variable `expect` instead of `except`.
@hernanat hernanat mentioned this pull request Jul 7, 2017
@m-13
Copy link

m-13 commented Nov 16, 2017

@danielmorrison Is this good to merge, or does it need any changes?

Copy link
Collaborator

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielmorrison danielmorrison merged commit e4c2fe4 into collectiveidea:master Dec 30, 2017
@hernanat hernanat deleted the rspec-typo-afh branch February 26, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants