Normalize options on initialization and minor cleanup #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbrisker
commented
Jan 9, 2018
lib/audited/auditor.rb
Outdated
| def normalize_audited_options | ||
| audited_options[:on] = Array.wrap(audited_options[:on]) | ||
| audited_options[:on] = [:create, :update, :destroy] if audited_options[:on].empty? | ||
| audited_options[:only] = Array.wrap(audited_options[:only]).map(&:to_s) if audited_options[:only] |
There was a problem hiding this comment.
We want to keep audited_options[:only]==nil if it wasn't specified since we use it to determine which columns to save.
tbrisker
force-pushed
the
normalizeoptions
branch
from
8254641 to
b5a5cba
Compare
Normalizing options passed on audited initialization simplifies code in further steps. Also cleaned up the code a bit.
tbrisker
force-pushed
the
normalizeoptions
branch
from
b5a5cba to
5497074
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalizing options passed on audited initialization simplifies code in
further steps. Also cleaned up the code a bit.