Fix migrations in tests for rails 5.2 #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatkodima
force-pushed
the
fix-tests-for-rails5.2
branch
from
dd0955a to
5df7c3b
Compare
tbrisker
requested changes
Jan 31, 2018
spec/audited_spec_helpers.rb
Outdated
| @@ -17,4 +17,12 @@ def create_versions(n = 2) | |||
| end | |||
| end | |||
|
|
|||
| def run_migrations(direction, migrations_paths, target_version = nil) | |||
| if Rails.version >= '5.2.0.0' | |||
There was a problem hiding this comment.
This will fail once 5.2.0 is out, since '5.2.0' >= '5.2.0.0' => false.
There was a problem hiding this comment.
ouch, extra zero.
Such Rails.version >= '5.2.0' will not work for .beta2, after which change was introduced. Should I bother of exactly greater than .beta2 or is Rails.version >= '5.2.0' enough?
There was a problem hiding this comment.
perhaps Rails.version.start_with? '5.2' for now, and change it later if needed for 6?
fatkodima
force-pushed
the
fix-tests-for-rails5.2
branch
from
5df7c3b to
4c61d32
Compare
|
Updated this to use exact version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 5.2.rc1 introduced some breaking changes for
ActiveRecord::Migrator, so this PR fixes tests according to new changes.