drop support for deprecated rails versions

[grosser]

No description provided.

[fatkodima]

This also can be removed

audited/lib/audited/auditor.rb

Line 165 in 9f6619c

revision.send :instance_variable_set, '@attributes', self.attributes if rails_below?('4.2.0')

[grosser]

done, good to go ?

[fatkodima]

Looks like readme should be changed here

Audited currently (4.x) works with Rails 5.1, 5.0 and 4.2. It may work with 4.1 and 4.0, but this is not guaranteed.

And added missing changelog entry.

Also this helper is not needed anymore

audited/lib/generators/audited/migration_helper.rb

Line 5 in 9f6619c

Rails::VERSION::MAJOR == 4 ? 'ActiveRecord::Migration' : "ActiveRecord::Migration[#{ActiveRecord::Migration.current_version}]"

[grosser]

helper is still needed since I'm not removing rails 4.2

[grosser]

updated and green

[grosser]

review plz

[fatkodima]

@tbrisker Did you proposed to delete all 4.x (so 4.2 as well) rails versions, or just 4.0 and 4.1?

[tbrisker]

I suggested dropping all in #430, but perhaps it would be better to split it in two and keep just 4.2 in the stable 4.x branch, considering that 4.{0,1} have not been officially supported for some time.

[tbrisker]

Looks good to me, I'll wait a few days before merging in case some folks have further input or disagreement in #430 regarding this.

[grosser]

don't think there is disagreement over dropping 4.0/4.1 ... just maybe 4.2 ... also I'll need this as base for other PRs to not merge-conflict myself :D

…

On Wed, Apr 4, 2018 at 6:45 AM, Tomer Brisker ***@***.***> wrote: ***@***.**** approved this pull request. Looks good to me, I'll wait a few days before merging in case some folks have further input or disagreement in #430 <#430> regarding this. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#431 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAsZ-66vD9A6yfIH5rnQTVu3SNjwBaGks5tlM6VgaJpZM4TC8MX> .

[tbrisker]

Considering we haven't been supporting them officially for at least 2 years, I guess it's safe to drop. Thanks @grosser !