Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve code coverage #437

Merged
merged 1 commit into from
Jun 24, 2018
Merged

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Apr 9, 2018

followup to #356

@tbrisker

@@ -139,12 +139,10 @@ def self.as_user(user, &block)

# @private
def self.reconstruct_attributes(audits)
attributes = {}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dripping untested and unused block feature

Copy link
Collaborator

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grosser and sorry for the slow turn around!

@tbrisker tbrisker merged commit 9c40fca into collectiveidea:master Jun 24, 2018
@grosser
Copy link
Contributor Author

grosser commented Jun 24, 2018

prefer to leave the PR number when merging, easier for tracking things down later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants