Use default Rails blank validation error message #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james
added a commit
to dxw/affordable-housing-monitoring
that referenced
this pull request
Nov 5, 2019
We had two bugs with the audited gem, and I've opened PRs for both of them: collectiveidea/audited#522 collectiveidea/audited#523 In the meantime, while we're waiting for them to hopefully be approved and merged, I have created my own fork with a branch that has both of those changes in. This means that we no longer need the monkey pathes in the dwelling and development models. Also update the specs to reflect the new, fixed error messages.
Replace the hardcoded error message for a blank audit comment with Rails' default. This meet's Rails' convention, and allows i18n support.
james
force-pushed
the
fix/use-default-rails-blank-error
branch
from
510eaf6 to
77cbb99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the hardcoded error message for a blank audit comment with Rails' default. This meet's Rails' convention, and allows i18n support.