Deadlocks from concurrent audit combinations #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When combining audits the oldest remaining audit is updated and the audits over max_audit count are deleted. This can result in a deadlock if if the same record is updated at the same time. However by virtue of being at the same time the same end is being selected and the same verion number is used for the delete. This means the same update and same delete are being performed for both audit combinations so this error can just be ignored.
danielmorrison
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When combining audits the oldest remaining audit is updated and the audits over max_audit count are deleted.
This can result in a deadlock if if the same record is updated at the same time. However by virtue of being at the same time
the same end is being selected and the same verion number is used for the delete. This means the same update and same delete
are being performed for both audit combinations so this error can just be ignored.