Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter encrypted attributes automatically #630

Conversation

vlad-psh
Copy link
Contributor

@vlad-psh vlad-psh commented Jul 5, 2022

Rails 7 introduces built-in attributes encryption: https://edgeguides.rubyonrails.org/active_record_encryption.html
Those are configured with encrypts keyword, eg: encrypts :password

Because these attributes are considered sensitive, we shouldn't write plain unencrypted values to our audits table by default.

Copy link
Member

@danielmorrison danielmorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems smart. Could you add a note to the README about this too?

@vlad-psh vlad-psh force-pushed the filter-encrypted-attributes-automatically branch from a74d7e4 to b5ec728 Compare July 5, 2022 14:35
@vlad-psh
Copy link
Contributor Author

vlad-psh commented Jul 5, 2022

@danielmorrison Thanks for comment!
I added small note to the README and also fixed specs for Rails < 7

@danielmorrison danielmorrison force-pushed the filter-encrypted-attributes-automatically branch from b5ec728 to 1bbc099 Compare December 23, 2022 16:40
@danielmorrison danielmorrison merged commit 68c2413 into collectiveidea:master Dec 23, 2022
dsinn

This comment was marked as off-topic.

@vlad-psh vlad-psh deleted the filter-encrypted-attributes-automatically branch January 6, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants