Allow Audited.audit_class= to receive a string class name and return …

[rocket-turtle]

…an class

[rocket-turtle]

Would it be better to remove the String case and add that to the Readme

#609 (comment)

ActiveSupport.on_load :active_record do
  Audited.audit_class = CustomAudit
end

I do not understand why this should not work. maybe phortx can describe the problem.
#609 (comment)

[ekohl]

Perhaps you should replace attr_writer with a manual implementation to avoid the overhead in the getter:

def audit_class=(cls)
  @audit_class = cls.is_a?(String) ? cls.constantize : cls
end

[rocket-turtle]

I had it like this in my first draft but I think it would not help.
The constantize would be called directly on the setting (in the initializer).

I think it would be the same as writing: Audited.audit_class = "CustomAudit".constantize

[ekohl]

Oh, that's an interesting thing. Perhaps a comment in the audit_class why it's there (like "it has to be lazy") could help future readers.

[rocket-turtle]

I tried to add a comment :)

[rocket-turtle]

I do not like this case but it is better than the old unmemorized audit_class.constantize in audit_model

[ekohl]

Thanks for this. I've opened theforeman/foreman#9595 to unpin again. Let's see if CI agrees this works :)