Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable automatic data integration testing #1173

Closed
collinbarrett opened this issue Nov 23, 2019 · 9 comments · Fixed by #1364
Closed

re-enable automatic data integration testing #1173

collinbarrett opened this issue Nov 23, 2019 · 9 comments · Fixed by #1364
Labels
bug something isn't working ops processes, devops, infrastructure

Comments

@collinbarrett
Copy link
Owner

Disabled auto data integration testing due to stack overflow being thrown by Azure Pipelines Agent.

https://dev.azure.com/collinbarrett/FilterLists/_build/results?buildId=1930

b44e7df

Closes #1129
@collinbarrett collinbarrett added ops processes, devops, infrastructure bug something isn't working labels Nov 23, 2019
@collinbarrett collinbarrett added the high priority must fix ASAP label Dec 21, 2019
@collinbarrett
Copy link
Owner Author

collinbarrett commented Dec 21, 2019 •
edited
Loading

Temporarily releasing an older version of the data (pre- #1268 ) due to stackoverflow exceptions. I need to re-architect the data seeding process as the data set seems to now be too big. Making this top priority, but might take me a couple weeks or so, depending on time.

@collinbarrett collinbarrett mentioned this issue Dec 21, 2019
Closed
@collinbarrett collinbarrett mentioned this issue Jan 10, 2020
Merged
@DandelionSprout
Copy link
Contributor

Is there any progress on this matter? I'm wary of taking care of much more of the backlog before I'd see that such efforts of mine would've had visible effect.

@collinbarrett
Copy link
Owner Author

It's top priority once I find some time, but just haven't had the time... Hopefully soon. Thanks.

@DandelionSprout DandelionSprout mentioned this issue Jan 30, 2020
Closed
@collinbarrett collinbarrett self-assigned this Feb 8, 2020
collinbarrett added a commit that referenced this issue Feb 8, 2020
@collinbarrett
try re-enabling data integration tests
8c3da24 
ref #1173
@collinbarrett
Copy link
Owner Author

@DandelionSprout The data on filterlists.com should be up to date now with what's in this repo. I am still working on getting the auto testing and auto deploying working properly, however. For now, future data changes will require manually testing before deploying.

@DandelionSprout
Copy link
Contributor

Much better than having no solution at all, I'd presume.

collinbarrett added a commit that referenced this issue Feb 10, 2020
@collinbarrett
re-enable data integration test (does not yet add new migrations)
54a5dee 
ref #1173
This was referenced Feb 11, 2020
Merged
Merged
@collinbarrett
Copy link
Owner Author

The new solution of using EF code first for the data and automatically adding migrations for PRs is very close to working. Just trying to overcome this hurdle.

@collinbarrett collinbarrett added the help wanted please help us resolve label Feb 12, 2020
@collinbarrett
Copy link
Owner Author

Note to self: update the docs to ask PR contributors to ensure they do this so the migration works properly.

@collinbarrett collinbarrett mentioned this issue Feb 12, 2020
Merged
@collinbarrett collinbarrett linked a pull request Feb 12, 2020 that will close this issue
testing adding migrations #1364
Merged
collinbarrett added a commit that referenced this issue Feb 12, 2020
@collinbarrett
various improvements to migration script
0da0309 
for #1173
@collinbarrett
Copy link
Owner Author

accidentally closed. still need a solution to https://stackoverflow.com/q/60188806/2343739

@collinbarrett collinbarrett reopened this Feb 12, 2020
collinbarrett pushed a commit that referenced this issue Feb 13, 2020
@DandelionSprout
February pull 2 (#1354)
87f1bb2 
* Update FilterList.json

* Update FilterListTag.json

* Update FilterListLanguage.json

* Update FilterListMaintainer.json

* Update TPLSubscriptionAssistant.html

* Update TPLSubscriptionAssistant.html

close #1345 
ref #1173
@collinbarrett
Copy link
Owner Author

This is mostly resolved now! Removing high priority flag. Cleanup still to be done:

  • Add docs so that PR contributors know to provide permissions to push to their PR branch.
  • Wrap up TODOs in Migrate Pipeline.

@collinbarrett collinbarrett removed help wanted please help us resolve high priority must fix ASAP labels Feb 13, 2020
@collinbarrett collinbarrett changed the title re-enable auto data integration testing Re-enable automatic data integration testing Feb 13, 2020
@collinbarrett collinbarrett linked a pull request Feb 13, 2020 that will close this issue
migrate updates #1367
Merged
@collinbarrett collinbarrett removed a link to a pull request Feb 13, 2020
migrate updates #1367
Merged
@collinbarrett collinbarrett mentioned this issue Feb 13, 2020
Merged
@collinbarrett collinbarrett changed the title Re-enable automatic data integration testing re-enable automatic data integration testing Feb 13, 2020
This was referenced Feb 15, 2020
Merged
Merged
@collinbarrett collinbarrett removed their assignment Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something isn't working ops processes, devops, infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

testing adding migrations collinbarrett/FilterLists
2 participants
@collinbarrett @DandelionSprout