Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect Software linked to filterListIds 223 and 615 #492

Closed
hawkeye116477 opened this issue Sep 17, 2018 · 4 comments
Closed

incorrect Software linked to filterListIds 223 and 615 #492

hawkeye116477 opened this issue Sep 17, 2018 · 4 comments
Labels
directory-data changes to basic FilterLists data feedback wanted provide your input

Comments

@hawkeye116477
Copy link
Contributor

hawkeye116477 commented Sep 17, 2018

Bug

On some lists there are wrong softwares, for example Polish Annoyance Filters - Unlocking Right Click isn't compatible with AdGuard, it's only compatible with uBO and Nano Adblocker, cuz I mostly only use script:inject rules, which AdGuard doesn't support. Also Official Polish Filters for AdBlock, uBlock Origin & AdGuard rather aren't compatible with DNS66, just like another lists for adblockers 😄.

@collinbarrett collinbarrett changed the title Wrong softwares assigned for lists incorrect Software linked to filterListIds 223 and 615 Sep 17, 2018
@collinbarrett
Copy link
Owner

collinbarrett commented Sep 17, 2018

Each list is assigned a syntax, and there is a many-to-many relationship between syntaxes and software.

So, for example:

Polish Annoyance Filters - Unlocking Right Click currently has a syntaxId = 4 (uBlock Origin Static). This syntax is currently configured as being supported by a list of software per the SoftwareSyntax and Software datasets.

So, to correct these bugs, we need to determine if the syntaxId for the list is incorrect, if the softwareSyntax link is incorrect, etc.

We'll have to correct these issues one-at-a-time. Do you have any suggestions for what might be wrong with these two lists?

Docs: https://github.com/collinbarrett/FilterLists/wiki

@collinbarrett collinbarrett added the directory-data changes to basic FilterLists data label Sep 17, 2018
@hawkeye116477
Copy link
Contributor Author

hawkeye116477 commented Sep 17, 2018

@collinbarrett I see that for DNS66 is assigned Adblock Syntax, so you should change that to hosts syntax. For Polish Annoyance Filters - Unlocking Right Click, probably you should create new syntax, maybe call it uBlock Origin's scriptlet injection or something like that and that should apply only to uBO and Nano Adblocker.

@collinbarrett
Copy link
Owner

Ok, sounds reasonable to me. If you have time to submit a PR, that'd be great. If not, I'll get to it when I can.

hawkeye116477 added a commit to hawkeye116477/FilterLists that referenced this issue Sep 17, 2018
@hawkeye116477 hawkeye116477 mentioned this issue Sep 17, 2018
@collinbarrett collinbarrett added the feedback wanted provide your input label Sep 17, 2018
@collinbarrett
Copy link
Owner

Feedback wanted: #493 (review)

hawkeye116477 added a commit to hawkeye116477/FilterLists that referenced this issue Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
directory-data changes to basic FilterLists data feedback wanted provide your input
Projects
None yet
Development

No branches or pull requests

2 participants