Triangle Logo, Closes Issue #2 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onionj
approved these changes
Sep 14, 2022
lnxpy
requested changes
Oct 18, 2022
There was a problem hiding this comment.
@SepehrRasouli, I think "logo" is not an acceptable name for this purpose. There could be a module called shapes.py and one of its items if something like TRIANGLE. (Upper-cased since its a constant variable)
I know I'm being so strict about that. Thank you for your patience Sepehr. :)
lnxpy
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @lnxpy, I fixed the last PR by changing the logo to make it look like what you've said.
It looks something like this :