Improve bindings of Database #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarlinpe
force-pushed
the
sarlinpe/database-bindings
branch
from
4dd4cb4 to
21d8581
Compare
sarlinpe
force-pushed
the
sarlinpe/database-bindings
branch
from
21d8581 to
362e1c1
Compare
ahojnnes
reviewed
Feb 13, 2024
ahojnnes
previously approved these changes
Feb 13, 2024
ahojnnes
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this PR:
FeatureKeypoint/FeatureKeypointsandFeatureMatch/FeatureMatchesare not Python-friendly, would it be OK to replace all their occurrences with their blob counterparts? NxD matrices are directly translated to numpy arrays. This would simplify the COLMAP code as well and also make it cleaner to support non-affine features.