Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom edit community form with ORCID iD #315

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Custom edit community form with ORCID iD #315

merged 3 commits into from
Nov 9, 2023

Conversation

barbarah
Copy link
Contributor

@barbarah barbarah commented Nov 8, 2023

This is the "edit community" based on the design: https://gui-prototype.colonialcollections.nl/community.html

This design contains:

  • A warning banner with ORCID iD
  • A new edit form, including the ORCID iD

I had some discussions with @Doppen about the new edit community form. This form missed a lot of features of the existing Clerk organization profile. And with the new design, the button to the Clerk organization profile was gone. We went through the missing features and decided what to do with them in an ideal situation:

  • Edit slug -> move to the new "edit community" form
  • Edit image -> move to a new form that opens when clicking on the image
  • "Leave Community" button -> Move to page (design needed)
  • "Delete Community" button -> Move to page (design needed)
  • Edit members (overview, invite, remove, change roles) -> Because this feature contains a lot of logic, use the page Clerk already provides.

In this pull request, I have included the first and last points. The other points would be nice but take some more work, and since Clerk already provides these features, I have added a button, "settings". This will open the settings tab of the Clerk organization profile. If we have time, we could remove the "settings" button and implement the features with our design.

Technical points

Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
colonial-collections-dataset-browser ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 0:48am
colonial-collections-researcher ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 0:48am

@barbarah barbarah requested a review from sdevalk November 8, 2023 10:50
@barbarah
Copy link
Contributor Author

barbarah commented Nov 8, 2023

The end-to-end tests fail because of the reason changes in the filters. I will fix this in a separate pull request.

Copy link
Contributor

@sdevalk sdevalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@barbarah barbarah merged commit fbdad82 into main Nov 9, 2023
5 of 6 checks passed
@barbarah barbarah deleted the edit-community branch November 9, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants