Adds support for more angle units #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for the angle units "grad", "rad", and "turn".
LeaVerou
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds support for the angle units "grad", "rad", and "turn".
Resolves #180.
Resolves #311.
Notes
I was implementing support for this in a project of mine and figured I contribute it here as well. I'm (now) aware of #181, so let me know if you'd rather incorporate that. Happy to close this again, if so.
Also, I did run the parser tests locally and they passed, but I saw about 75 of the tests failing locally and I'm not sure whether that's just something with my environment, so it would be good to double check this.