Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix number parsing #508

Merged
merged 2 commits into from
May 1, 2024
Merged

Fix number parsing #508

merged 2 commits into from
May 1, 2024

Conversation

facelessuser
Copy link
Collaborator

Ref #507

@netlify Netlify
Copy link

netlify bot commented Apr 26, 2024 •
edited
Loading

✅ Deploy Preview for colorjs ready!

Name Link
🔨 Latest commit 2c58c35
🔍 Latest deploy log https://app.netlify.com/sites/colorjs/deploys/662c0902bab8ea00085080e9
😎 Deploy Preview https://deploy-preview-508--colorjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facelessuser
Copy link
Collaborator Author

I only updated linting related to this pull. Other lint issues should be fixed in a separate PR.

@LeaVerou
Copy link
Member

Closes #509

LeaVerou
LeaVerou reviewed Apr 26, 2024
View reviewed changes
src/util.js Outdated Show resolved Hide resolved
LeaVerou
LeaVerou reviewed Apr 26, 2024
View reviewed changes
test/parse.js Outdated Show resolved Hide resolved
LeaVerou
LeaVerou approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@LeaVerou LeaVerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this!

@svgeesus svgeesus closed this May 1, 2024
@svgeesus svgeesus reopened this May 1, 2024
@svgeesus
Copy link
Member

svgeesus commented May 1, 2024

Come on, stupid bot

@svgeesus svgeesus merged commit a77e080 into color-js:main May 1, 2024
4 of 6 checks passed
@svgeesus svgeesus mentioned this pull request May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeaVerou LeaVerou LeaVerou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@facelessuser @LeaVerou @svgeesus