Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary is_terminal dependency #149

Merged
merged 3 commits into from
Dec 10, 2023
Merged

Remove unnecessary is_terminal dependency #149

merged 3 commits into from
Dec 10, 2023

Conversation

Oakchris1955
Copy link
Contributor

Since Rust version 1.70.0, the built-in IsTerminal trait is now stabilized, which means that the is_terminal dependency is now unnecessary. However, this change also means that the version of the rustc compiler must to be greater than 1.70.0

@Oakchris1955
Remove unnecessary dependency
7147d0a 
Replaced the IsTerminal trait from the is_terminal crate with the built-in IO IsTerminal, which is stabilized since rustc 1.70.0
@Oakchris1955 Oakchris1955 mentioned this pull request Jul 21, 2023
Closed
@Oakchris1955
Update test overflow
53dc01a 
Change minimum required Rust version to 1.70
@Oakchris1955
Update README and CHANGELOG
d50b129
@Oakchris1955
Copy link
Contributor Author

Commit 53dc01a should fix the errors from the workflow runs. I think commit d50b129 is self-descriptive

@kurtlawrence kurtlawrence added the bump-minor New non-breaking features label Dec 10, 2023
@kurtlawrence kurtlawrence merged commit e467ebb into colored-rs:master Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtlawrence kurtlawrence kurtlawrence approved these changes

Assignees
No one assigned
Labels
bump-minor New non-breaking features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oakchris1955 @kurtlawrence