Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Scala 2.13.0-M5 to cross-build #6

Closed
wants to merge 1 commit into from

Conversation

SethTisue
Copy link

No description provided.

@alexarchambault
Copy link
Collaborator

ping @lihaoyi

@lihaoyi
Copy link
Member

lihaoyi commented Dec 21, 2018

@alexarchambault gave you commit access, since you seem to be doing a lot of 213 related stuff feel free to go wild

@alexarchambault
Copy link
Collaborator

@SethTisue Couldn't we manage not to rely on sbt-buildinfo, or at least not have it add public stuff in the main module? The scala version is already available via scala.util.Properties.versionNumberString (may require forking in tests to work right), and the cross stuff could be deduced via platform-specific sources under geny/{js, jvm}/src/.

@lihaoyi
Copy link
Member

lihaoyi commented Dec 31, 2018

Honestly I'd just be happy with it saying x == "WrappedArray(...)" || x == "WrappedVarArgs(...)". The chances of that looseness causing a regression to slip through are just about zero

@ajrnz
Copy link
Collaborator

ajrnz commented Jan 15, 2019

This should be implemented by #7 - shout if not

@ajrnz ajrnz closed this Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants