Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail, if a build.{sc,mill} is found in sub-directories #3921

Closed
lefou opened this issue Nov 7, 2024 · 0 comments · Fixed by #3954
Closed

Don't fail, if a build.{sc,mill} is found in sub-directories #3921

lefou opened this issue Nov 7, 2024 · 0 comments · Fixed by #3954
Labels
good-first-issue The fix/solution for the issue is considered easy. A good starting point for newbies.
Milestone

Comments

@lefou
Copy link
Member

lefou commented Nov 7, 2024

Mill currently fails with an error message when it detects a build.sc or build.mill file in a sub-directory. This isn't an issue in any way, so it should just ignore it. Printing a warning message might be an option, but I currently don't see why this is even a worth a warning.

IMHO the most likely situation where users might want to be warned is, when we detect a package.mill file next to an build.mill. This means, that a directory is a root project as well as a sub-project. This is not an issue per se, but package.mill files further down the directory hierarchy might be ending up in both Mill projects, which can be wanted or not.

@lefou lefou added the good-first-issue The fix/solution for the issue is considered easy. A good starting point for newbies. label Nov 7, 2024
lefou pushed a commit that referenced this issue Nov 13, 2024
If a directory is both used as a root project and a sub-project,
`build.{sc,mill,mill.scala}` and `package.{sc,mill,mill.scala}` may
exist together. Simply ignore them in corresponding situations should be
safe.

Fix #3921

Pull request: #3954
@lefou lefou added this to the 0.12.3 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue The fix/solution for the issue is considered easy. A good starting point for newbies.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant