Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for -scala-output-version flag #1764

Closed

Conversation

prolativ
Copy link

@prolativ prolativ commented Mar 4, 2022

WIP

@lefou lefou marked this pull request as draft March 5, 2022 20:48
@lefou
Copy link
Member

lefou commented Apr 4, 2022

It would be nice, if you could update the PR description with a short summary of what this PR does and probably a link to the respective feature in the Scala compiler. Can you give a rough estimate, when this feature is going to be consumable in scalac and hence this PR should be merged? Maybe some ticket we can link to?

@lefou lefou linked an issue Apr 4, 2022 that may be closed by this pull request
@lefou
Copy link
Member

lefou commented Apr 4, 2022

/**
* Like [[resolvedIvyDeps]] but used only for compiling this module .
*/
def resolvedCompilationIvyDeps: T[Agg[PathRef]] = resolvedIvyDeps
Copy link
Member

@lefou lefou Apr 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not that happy with this name. First, there is a high change of reading it as resolvedCompileIvyDeps which would be the dual of compileIvyDeps (which currently does not exists). Also, the scaladoc gives no clear idea, why this is needed exactly and what's the difference to resolvedIvyDeps.

@@ -57,6 +58,8 @@ trait ScalaModule extends JavaModule { outer =>
*/
def scalaVersion: T[String]

def scalaOutputVersion: T[String] = scalaVersion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we need some scaladoc explaining its purpose and also the distinction to scalaVersion.

@lolgab
Copy link
Member

lolgab commented Apr 13, 2022

Scala 3.1.2 was released and the companion Sbt PR was merged.
sbt/sbt#6814

@lolgab
Copy link
Member

lolgab commented Jun 17, 2022

Since the compiler team decided to drop the -scala-output-version flag we don't need to support it anymore.

@lolgab lolgab closed this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Scala 3 -Yscala-output-version flag
3 participants