-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for -scala-output-version flag #1764
Conversation
It would be nice, if you could update the PR description with a short summary of what this PR does and probably a link to the respective feature in the Scala compiler. Can you give a rough estimate, when this feature is going to be consumable in scalac and hence this PR should be merged? Maybe some ticket we can link to? |
/** | ||
* Like [[resolvedIvyDeps]] but used only for compiling this module . | ||
*/ | ||
def resolvedCompilationIvyDeps: T[Agg[PathRef]] = resolvedIvyDeps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not that happy with this name. First, there is a high change of reading it as resolvedCompileIvyDeps
which would be the dual of compileIvyDeps
(which currently does not exists). Also, the scaladoc gives no clear idea, why this is needed exactly and what's the difference to resolvedIvyDeps
.
@@ -57,6 +58,8 @@ trait ScalaModule extends JavaModule { outer => | |||
*/ | |||
def scalaVersion: T[String] | |||
|
|||
def scalaOutputVersion: T[String] = scalaVersion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we need some scaladoc explaining its purpose and also the distinction to scalaVersion
.
Scala 3.1.2 was released and the companion Sbt PR was merged. |
Since the compiler team decided to drop the |
WIP