Improve Mill plugin classpath exclusions #3221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is some commented out code. Is it supposed to be there? |
Kind of. It's the rest of the full transitive dependency chain, which I preserved/snapshot-ed that way. I need to make up my mind, if we need to handle/check them too in the test, or not. |
I removed them for now. |
|
You can also merge main or rebase |
lolgab
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refer to transitive modules coordinates in the
BuildInfo.millEmbededDepsdata field.Added an integration test to make sure it's effectively excluding transitive Mill dependencies.
Fix #3207