Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new kotlin examples into docsite #3592

Merged
merged 13 commits into from
Sep 23, 2024

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Sep 23, 2024

Apart from adding .adoc pages for all the kotlin examples #3585 #3589 #3555 and the palantir java format example from https://github.com/com-lihaoyi/mill/pulls?page=2&q=is%3Apr+is%3Aclosed, I moved some docs around: the first few things under Foo Example Builds really belong under Foo Module Configuration, the external/libraries/ folder should be in depth/libraries/

The test for Custom Main Argument Parsers seems to have bitrotted since it was implemented, and it accidentally wasn't running in the test suite before so we didn't notice. For now just disabling that test and we can fix it later

@lihaoyi lihaoyi marked this pull request as ready for review September 23, 2024 04:19
@lihaoyi lihaoyi merged commit b06486c into com-lihaoyi:main Sep 23, 2024
24 checks passed
@lefou lefou added this to the 0.12.0-RC3 milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants