-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first class Javascript/Typescript support to the Mill build tool #4127
base: main
Are you sure you want to change the base?
Conversation
I've taken a glance at this and it isn't really sufficient. Please look at the Java/Kotlin/Scala equivalents of these pages and see what is expected |
- resource handling in TsModule
- resource handling in bundling
# Conflicts: # javascriptlib/src/mill/javascriptlib/TestModule.scala # javascriptlib/src/mill/javascriptlib/TypeScriptModule.scala
example/javascriptlib/basic/6-client-server-realistic/build.mill
Outdated
Show resolved
Hide resolved
example/javascriptlib/module/4-compilation-execution-flags/build.mill
Outdated
Show resolved
Hide resolved
- clean :)
rm out/ directory in 5-resources
|
Fixed failing tests |
Some last few comments, otherwise just need to flesh out the documentation for all the |
I think the code looks good enough for now. Please fix up the docs to include proper english explanations of every example, and ensure that the test-docs CI job passes, then we can merge it |
This pr implements the examples for jslib/module.
#3927
Key Changes:
@<module-name>/resources
or custom resources files in user defined custom resource path can be imported globally@<module-name>/resources-directory
/test
Implements Task generatedSources
@generated/generated-file-name
Note:
For
example/javascriptlib/module/3-override-tasks/
, the foo directory needs to exist, hence the filefoo/readme.md
, code sources are generated from its .mill fileChecklist