Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shutdown hook failures in tests #422

Merged

Conversation

aosagie
Copy link
Contributor

@aosagie aosagie commented Sep 1, 2018

Currently, any tests that use shutdown hooks fails to properly shutdown due to the context class loader being switched out before the shutdown hooks run. I don't feel great about this solution (due to the introduction of a potential side-effect to Jvm.inprocess), but it works.

Here's an example of running Apache Spark tests.
Before
screenshot from 2018-09-01 06-20-37
After
screenshot from 2018-09-01 06-16-13

BTW, thanks for making Mill so easy to hack on. I love "dev.run".

@aosagie aosagie changed the title Fix/shutdown hook manager failure Fix shutdown hook failures in tests Sep 1, 2018
@lihaoyi
Copy link
Member

lihaoyi commented Sep 2, 2018

Thanks!

@lihaoyi lihaoyi merged commit a6efead into com-lihaoyi:master Sep 2, 2018
@lefou lefou added this to the 0.2.8 milestone Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants