Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Http4s TodoMVC Example #4446

Merged
merged 2 commits into from
Feb 1, 2025
Merged

Add Http4s TodoMVC Example #4446

merged 2 commits into from
Feb 1, 2025

Conversation

armanbilge
Copy link
Contributor

Closes #4433

@lihaoyi
Copy link
Member

lihaoyi commented Feb 1, 2025

Thanks @armanbilge. Some notes:

  • Trying to add a new todo and pressing Enter seems to make the whole UI disappear
  • Can you use port 8084, to avoid conflict with the 1-webapp example that already uses 8080?

@armanbilge
Copy link
Contributor Author

Trying to add a new todo and pressing Enter seems to make the whole UI disappear

Sorry, I stepped on a footgun 😅 (http4s/http4s#7054 (comment)). I realized none of the JSON/Circe stuff is used, so I removed it.

Can you use port 8084, to avoid conflict with the 1-webapp example that already uses 8080?

👍

@lihaoyi
Copy link
Member

lihaoyi commented Feb 1, 2025

Is the .debug call still necessary?

@lihaoyi lihaoyi merged commit 35b24b1 into com-lihaoyi:main Feb 1, 2025
31 checks passed
@lihaoyi
Copy link
Member

lihaoyi commented Feb 1, 2025

going to close thtis for now. @armanbilge can email me your international bank transfer details and i will close out the bounty

@lefou lefou added this to the 0.12.7 milestone Feb 1, 2025
@armanbilge armanbilge mentioned this pull request Feb 1, 2025
lihaoyi pushed a commit that referenced this pull request Feb 1, 2025
gamlerhart pushed a commit to gamlerhart/mill that referenced this pull request Feb 9, 2025
gamlerhart pushed a commit to gamlerhart/mill that referenced this pull request Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Http4s TodoMVC Example (500USD bounty)
3 participants