New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for Windows os.root() with slash error #235

Merged

lefou merged 1 commit into com-lihaoyi:main from philwalk:fix-root-slash-in-Windows

Nov 15, 2023

Contributor

philwalk commented Nov 15, 2023

This fixes #234 and adds a unit test.


          fix for os.root("C:/") error

82c8b2c

philwalk mentioned this pull request

os.root("C:/") fails in Windows #234

Closed

lefou approved these changes

View reviewed changes

Member

lefou left a comment

Looks good to me. Thank you!

lefou merged commit fd44104 into com-lihaoyi:main

9 checks passed

lefou added this to the after 0.9.2 milestone

philwalk deleted the fix-root-slash-in-Windows branch

November 15, 2023 16:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet