Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove uneeded Numeric constraint #47

Conversation

scarf005
Copy link
Contributor

@scarf005 scarf005 commented Dec 9, 2024

fixes #46

image

Side note

image

some of these implicit qrs aren't used; could've removed it but kept because it might break existing functions that passed them explicitly

@scarf005 scarf005 changed the title fix: remove unused Numeric constraint fix: remove unused Numeric constraint Dec 9, 2024
@scarf005 scarf005 changed the title fix: remove unused Numeric constraint fix: remove uneeded Numeric constraint Dec 9, 2024
@lihaoyi lihaoyi merged commit 146dc4b into com-lihaoyi:main Dec 10, 2024
6 checks passed
@lihaoyi
Copy link
Member

lihaoyi commented Dec 10, 2024

Thanks @scarf005 , I pushed the tag for 0.1.13 so hopefully it should be available soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AggOps.maxBy expects Numeric[T] for no reason
2 participants