Update Scala to 3.0.0-RC1 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
commented
Feb 17, 2021
| @@ -189,8 +189,14 @@ object Macros { | |||
| owner match { | |||
| case defSym if defSym.isDefDef => | |||
| defSym.tree.asInstanceOf[DefDef].paramss | |||
| // FIXME Could be a List[TypeDef] too, although I'm not | |||
| // under which conditions this can happen… | |||
| .map(_.asInstanceOf[List[ValDef]]) | |||
There was a problem hiding this comment.
paramss is a List[ParamClause[T], with ParamClause[T] being List[ValDef[T]] | List[TypeDef[T]]. So we can't just match paramss with
paramss match {
case l: List[ValDef] =>
case l: List[TypeDef] =>
}because of type erasure.
| case classSym if classSym.isClassDef => | ||
| classSym.tree.asInstanceOf[ClassDef].constructor.paramss | ||
| // FIXME Could be a List[TypeDef] too, although I'm not | ||
| // under which conditions this can happen… | ||
| .map(_.asInstanceOf[List[ValDef]]) |
There was a problem hiding this comment.
Same as above.
alexarchambault
force-pushed
the
scala-3.0.0-RC1
branch
from
a8581fa
to
f49baed
Compare
smarter
reviewed
Feb 17, 2021
| @@ -189,8 +189,14 @@ object Macros { | |||
| owner match { | |||
| case defSym if defSym.isDefDef => | |||
| defSym.tree.asInstanceOf[DefDef].paramss | |||
| // FIXME Could be a List[TypeDef] too, although I'm not | |||
| // sure under which conditions this can happen… | |||
There was a problem hiding this comment.
It can currently happen with extension methods with a type parameter clause on the extension block and the method itself (cf scala/scala3#10940), and in the (post-3.0) future we plan to allow users to add type parameter clauses after term parameter clauses in all methods.
This was referenced Feb 18, 2021
anatoliykmetyuk
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.