Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#111 Fix Args in Scala 3 #126

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

arainko
Copy link
Contributor

@arainko arainko commented May 3, 2023

Fixes #111

This PR fixes the behavior of Args in Scala 3 - the values are now actually there.

@arainko arainko changed the title #11 Fix Args in Scala 3 #111 Fix Args in Scala 3 May 3, 2023
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@lefou lefou merged commit d696093 into com-lihaoyi:master May 4, 2023
@joan38
Copy link

joan38 commented Sep 21, 2023

Hi , I'm impacted by this.
Is there a release of this?

@joan38
Copy link

joan38 commented Sep 21, 2023

Sounds like not.
@lefou can we cut a release? The last one was over a year ago

@lefou
Copy link
Member

lefou commented Sep 22, 2023

@joan38 If no maintainer will do it, I can squeeze it into my FOSS todo list. ;)

@joan38
Copy link

joan38 commented Sep 22, 2023

It would be nice please as we are blocked on this to upgrade to Scala 3.
It should be a matter of pushing a new tag right?

@lefou
Copy link
Member

lefou commented Sep 22, 2023

It would be nice please as we are blocked on this to upgrade to Scala 3.

Done.

It should be a matter of pushing a new tag right?

Technically yes, but no. Cutting a release is more than "just" creating a tag, at least if you have more than three users and care about them. It's also editing a changelog, reviewing stuff etc.

@joan38
Copy link

joan38 commented Sep 22, 2023

Ah yes this is true!
Thanks @lefou greatly appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why doesn't sourcecode.Args capture argument values under Scala 3?
3 participants