OPIK-75: Add batch spans creation endpoint #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagohora
force-pushed
the
thiagohora/batch_spans_creation
branch
2 times, most recently
from
9910e26
to
05028fd
Compare
thiagohora
force-pushed
the
thiagohora/batch_spans_creation
branch
from
05028fd
to
3b68fd1
Compare
andrescrz
requested changes
Sep 11, 2024
apps/opik-backend/src/main/java/com/comet/opik/api/SpanBatch.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/SpanDAO.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/SpanDAO.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/SpanDAO.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/SpanDAO.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/SpanDAO.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/SpanDAO.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/SpanService.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/utils/JsonUtils.java
Outdated
Show resolved
Hide resolved
thiagohora
force-pushed
the
thiagohora/batch_spans_creation
branch
from
bee108a
to
e03b560
Compare
andrescrz
reviewed
Sep 13, 2024
apps/opik-backend/src/main/java/com/comet/opik/domain/SpanDAO.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/SpanService.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/SpanService.java
Outdated
Show resolved
Hide resolved
| .toList(); | ||
| } | ||
|
|
||
| private Mono<Project> resolveProject(String projectName) { |
There was a problem hiding this comment.
I believe a method already exists in this service for this. Let's avoid the duplication if possible.
There was a problem hiding this comment.
This method is already reusing the create logic. We check if it's empty
There was a problem hiding this comment.
Minor: looking at the latest code, this extra method isn't doing much , you can clean it up and just directly call
getOrCreateProject(WorkspaceUtils.getProjectName(projectName))
apps/opik-backend/src/main/java/com/comet/opik/domain/SpanService.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/test/java/com/comet/opik/api/resources/v1/priv/SpansResourceTest.java
Show resolved
Hide resolved
thiagohora
force-pushed
the
thiagohora/batch_spans_creation
branch
5 times, most recently
from
3fcfbdd
to
c6b6d46
Compare
thiagohora
force-pushed
the
thiagohora/batch_spans_creation
branch
from
c6b6d46
to
9735090
Compare
thiagohora
changed the title
andrescrz
approved these changes
Sep 13, 2024
| :name<item.index>, | ||
| :type<item.index>, | ||
| parseDateTime64BestEffort(:start_time<item.index>, 9), | ||
| if(:end_time<item.index> IS NULL, NULL, parseDateTime64BestEffort(:end_time<item.index>, 9)), |
There was a problem hiding this comment.
Minor: there's also a parseDateTimeBestEffortUSOrNull function:
Comment on lines
+495
to
+497
| public Mono<Long> batchInsert(@NonNull List<Span> spans) { | ||
|
|
||
| Preconditions.checkArgument(!spans.isEmpty(), "Spans list must not be empty"); |
There was a problem hiding this comment.
Minor: alternatively, you can remove the @NonNull annotation and do both checks in one go with CollectionUtils.isNotEmpty.
Comment on lines
+255
to
+257
| public Mono<Long> create(@NonNull SpanBatch batch) { | ||
|
|
||
| Preconditions.checkArgument(!batch.spans().isEmpty(), "Batch spans must not be empty"); |
| .toList(); | ||
| } | ||
|
|
||
| private Mono<Project> resolveProject(String projectName) { |
There was a problem hiding this comment.
Minor: looking at the latest code, this extra method isn't doing much , you can clean it up and just directly call
getOrCreateProject(WorkspaceUtils.getProjectName(projectName))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Add endpoint to batch create spans.
POST /v1/private/spans/batchIssues
Resolves #OPIK-75
Testing
Documentation