Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove un-necessary dependency from the Python SDK #331

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Remove un-necessary dependency from the Python SDK #331

merged 1 commit into from
Oct 2, 2024

Conversation

Lothiraldan
Copy link
Member

Details

Remove un-necessary dependency from the Python SDK

@Lothiraldan Lothiraldan requested a review from a team as a code owner October 2, 2024 08:38
@jverre
Copy link
Collaborator

jverre commented Oct 2, 2024

@japdubengsub Can you approve and merge if it looks good ?

andrescrz
andrescrz approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@andrescrz andrescrz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SDK shouldn't require the installer. Also, the SDK end to end tests, although not complete, they pass.

Please make any other further verification from your side, but this is reasonable to go. Thanks for taking care.

@ferc ferc merged commit ff64b84 into main Oct 2, 2024
21 checks passed
@ferc ferc deleted the Lothiraldan-patch-2 branch October 2, 2024 11:26
dsblank pushed a commit that referenced this pull request Oct 4, 2024
@Lothiraldan
Remove un-necessary dependency from the Python SDK (#331)
0af49c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrescrz andrescrz andrescrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lothiraldan @jverre @andrescrz @ferc